tisonkun commented on PR #39: URL: https://github.com/apache/datasketches-rust/pull/39#issuecomment-3682314968
> > I just found that we've implemented murmur3hash ourselves, while Java also implements xxhash. > > I think we should wait for sketches that need xxhash before shipping it ourselves. cc @tisonkun Agree. We can hold this PR for now. Whether or not publish the hash function is still under discussion, somehow datasketches-java and dataskecthes-cpp use them internally and datasketches-go clearly define the hash function internally. Seems mainly BloomFilter uses XxHash. @PsiACE you can take a look at #5 to see where we can have those sketches and xxhash as part of its implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
