leerho commented on code in PR #705:
URL: https://github.com/apache/datasketches-java/pull/705#discussion_r2641449700
##########
src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java:
##########
@@ -49,40 +49,52 @@
for (int i = 0; i < len; i++) {
sketch1.update(strArrArr[i], strArrArr[i]);
}
+ println("Sketch1");
+ printSummaries(sketch1.iterator());
+
sketch1.update(strArrArr[0], strArrArr[0]); //insert duplicate
+ println("Sketch1 updated with a duplicate");
printSummaries(sketch1.iterator());
- byte[] array = sketch1.toByteArray();
- MemorySegment wseg = MemorySegment.ofArray(array);
+
+ MemorySegment wseg = MemorySegment.ofArray(sketch1.toByteArray());
Review Comment:
This is total hallucination. There is no such method as
toByteArrayViaCppSerializer().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
