tisonkun commented on code in PR #45: URL: https://github.com/apache/datasketches-rust/pull/45#discussion_r2652317349
########## datasketches/src/theta/mod.rs: ########## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Theta sketch implementation for cardinality estimation. +//! +//! Theta sketch is a generalization of the Kth Minimum Value (KMV) sketch that uses +//! a hash table to store retained entries and a theta parameter (sampling threshold) +//! to control memory usage. When the hash table reaches capacity, theta is reduced +//! to maintain the nominal size k. +//! +//! # Overview +//! +//! Theta sketches provide approximate distinct count (cardinality) estimation with +//! configurable accuracy and memory usage. The implementation supports: +//! +//! - **ThetaSketch**: Mutable sketch for building from input data +//! - **CompactThetaSketch**: Immutable sketch for serialization and set operations +//! - **ThetaUnion**: For computing union of multiple theta sketches +//! - **ThetaIntersection**: For computing intersection of multiple theta sketches +//! +//! # Serialization +//! +//! Sketches can be serialized and deserialized while preserving all state, enabling +//! cross-platform sketch exchange with other Apache DataSketches implementations +//! (Java, C++, Python). Review Comment: I tend to remove this section until we implement it. ########## datasketches/src/theta/mod.rs: ########## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Theta sketch implementation for cardinality estimation. +//! +//! Theta sketch is a generalization of the Kth Minimum Value (KMV) sketch that uses +//! a hash table to store retained entries and a theta parameter (sampling threshold) +//! to control memory usage. When the hash table reaches capacity, theta is reduced +//! to maintain the nominal size k. +//! +//! # Overview +//! +//! Theta sketches provide approximate distinct count (cardinality) estimation with +//! configurable accuracy and memory usage. The implementation supports: +//! +//! - **ThetaSketch**: Mutable sketch for building from input data +//! - **CompactThetaSketch**: Immutable sketch for serialization and set operations +//! - **ThetaUnion**: For computing union of multiple theta sketches +//! - **ThetaIntersection**: For computing intersection of multiple theta sketches Review Comment: Ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
