tisonkun commented on code in PR #44:
URL: https://github.com/apache/datasketches-rust/pull/44#discussion_r2653444420
##########
datasketches/tests/frequencies_serialization_test.rs:
##########
@@ -128,7 +128,11 @@ fn test_cpp_frequent_longs_compatibility() {
let sketch = FrequentItemsSketch::<i64>::deserialize(&bytes, serde);
if cfg!(windows) {
if let Err(err) = sketch {
- assert!(matches!(err, SerdeError::InsufficientData(_)));
+ assert_eq!(err.kind(), ErrorKind::InvalidData);
+ assert!(
Review Comment:
nit: googletest has a contains matcher that can provide a better error
message without manual construct.
https://docs.rs/googletest/latest/googletest/matchers/fn.contains.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
