ZENOTME opened a new issue, #707: URL: https://github.com/apache/datasketches-java/issues/707
From exception, BinomialBoundsN is expect to not take the 0 theta.(To prevent "divide 0" happend). https://github.com/apache/datasketches-java/blob/b1d07af37eaa508915bd40559184974bf424f837/src/main/java/org/apache/datasketches/thetacommon/BinomialBoundsN.java#L276 But actually it doesn't check whether theta is 0. Following test is fail to check this because this test will pass if any `checkArgs` throw exception. ``` @Test public static void checkCheckArgs() { try { checkArgs(-1L, 1.0, 1); checkArgs(10L, 0.0, 1); checkArgs(10L, 1.01, 1); checkArgs(10L, 1.0, 3); checkArgs(10L, 1.0, 0); checkArgs(10L, 1.0, 4); fail("Expected SketchesArgumentException"); } catch (final SketchesArgumentException e) { //pass } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
