Fengzdadi commented on issue #90: URL: https://github.com/apache/datasketches-go/issues/90#issuecomment-3707566502
> There's no need for the longs sketch if there's a generic version. It was just done in java to ensure everything was working correctly prior to making a generic sampling sketch. > > For c++ there's only a templatized version since you can use that with primitives. And we had a known-working version to compare against by then. Got it, thanks for the explanation! I'll refactor to a generic `ReservoirItemsSketch[T]` instead. Will update the PR when ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
