tisonkun commented on code in PR #62:
URL: https://github.com/apache/datasketches-rust/pull/62#discussion_r2667138354
##########
tools/generate_serialization_test_data.py:
##########
@@ -73,8 +74,24 @@ def generate_java_files(workspace_dir, project_dir):
repo_url = "https://github.com/apache/datasketches-java.git";
run_command(["git", "clone", repo_url, str(temp_dir)])
+ # Upstream surefire excludes the generate_java_files group by default;
drop that exclusion in the temp clone.
+ pom_path = temp_dir / "pom.xml"
+ pom_text = pom_path.read_text()
+ pom_text = pom_text.replace(
+
"${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files},\n${testng.check-cpp-historical-files}",
+
"${testng.check-cpp-files},${testng.check-go-files},${testng.check-cpp-historical-files}",
+ )
+ pom_path.write_text(pom_text)
+
# 5. Run Maven to generate files
- mvn_cmd = ["mvn", "test", "-P", "generate-java-files"]
+ mvn_cmd = [
+ "mvn",
+ "test",
+ "-P",
+ "generate-java-files",
+ "-Dsurefire.groups=generate_java_files",
+ "-Dsurefire.excludedGroups=",
+ ]
Review Comment:
I think there should be a way to run a `mvn` command to execute the exact
group without modifying the pom.xml file.
cc @leerho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
