My +1 binding

I checked:

- [x]  Download links are valid.
- [x]  Checksums and signatures.
- [x]  LICENSE/NOTICE files exist
- [x]  No unexpected binary files
- [x]  All source files have ASF headers
- [x]  Can compile from source and run tests (macOS 26.2, Apple M2 Pro)

Best,
tison.


tison <[email protected]> 于2026年1月13日周二 13:11写道:

> > But it is related to any user that wishes to build from source and then
> test.
> File an issue at https://github.com/apache/datasketches-rust/issues/68.
>
>
> Best,
> tison.
>
>
> Lee Rhodes <[email protected]> 于2026年1月12日周一 03:53写道:
>
>> But it is related to any user that wishes to build from source and then
>> test.
>>
>> On Sat, Jan 10, 2026 at 6:03 PM tison <[email protected]> wrote:
>>
>>> Thanks for your verification!
>>>
>>> > It is helpful to have a link to the "Build & Test Guide" of the
>>> README.md file of the release itself
>>>
>>> Reasonable. Let me consider adding it to README.md or linking to some
>>> other file (VERIFY-RELEASE.md?), since it's unrelated to most downstream
>>> users.
>>>
>>>
>>> Best,
>>> tison.
>>>
>>>
>>> Lee Rhodes <[email protected]> 于2026年1月11日周日 09:28写道:
>>>
>>>> +1 (binding)
>>>> I checked:
>>>> - GPG, 512 signatures OK
>>>> - created the serialization_test_data OK
>>>> - ran cargo x test:
>>>>
>>>> test result: ok. 86 passed; 0 failed; 0 ignored; 0 measured; 0
>>>> filtered out; finished in 15.19s
>>>>
>>>> Suggestion: when we publish a vote for a release on dev@ we need to be
>>>> conscious of the fact that not all of our voting community is familiar with
>>>> the conventions of the language you are releasing in. It is helpful to have
>>>> a link to the "Build & Test Guide" of the README.md file of the release
>>>> itself, where there should be full instructions, even for novices with your
>>>> language, on how to download the code, and execute the tests, including
>>>> preliminary steps like installing test files, etc.
>>>>
>>>> This is not perfect, by any means, but here is our recent release vote
>>>> request for ds-java 9.0.0:
>>>> https://lists.apache.org/thread/6073bw2rz00zsnk8ngnxskkqdfs8x3qv
>>>>
>>>> Lee.
>>>>
>>>> On Fri, Jan 9, 2026 at 4:06 PM tison <[email protected]> wrote:
>>>>
>>>>> Seems they are about serialization tests, where the test file should
>>>>> be generated first.
>>>>>
>>>>> You can run:
>>>>>   ./tools/generate_serialization_test_data.py
>>>>>
>>>>> The test failure also tells:
>>>>>
>>>>> thread 'test_java_bloom_n30000000_h3' panicked at
>>>>> datasketches/tests/common.rs:38:9:
>>>>> serialization test data file not found:
>>>>> /Users/tison/Labs/datasketches-rust/datasketches/tests/serialization_test_data/java_generated_files/
>>>>> bf_n30000000_h3_java.sk
>>>>>
>>>>>             Please ensure test data files are present in the
>>>>> repository. Generally, you can
>>>>>             run the following commands from the project root to
>>>>> regenerate the test data files
>>>>>             if they are missing:
>>>>>
>>>>>             $ ./tools/generate_serialization_test_data.py
>>>>>
>>>>> Best,
>>>>> tison.
>>>>>
>>>>>
>>>>> Lee Rhodes <[email protected]>于2026年1月10日 周六07:53写道:
>>>>> >
>>>>> > - I checked the GPG & SHA512 signatures: OK
>>>>> > - when running "cargo x test" I got 78 tests passed, but 16 of the
>>>>> cpp_bloom tests failed:
>>>>> >
>>>>> > failures:
>>>>> >   test_cpp_bloom_n0_h3
>>>>> >   test_cpp_bloom_n0_h5
>>>>> >   test_cpp_bloom_n10000_h3
>>>>> >   test_cpp_bloom_n10000_h5
>>>>> >   test_cpp_bloom_n2000000_h3
>>>>> >   test_cpp_bloom_n2000000_h5
>>>>> >   test_cpp_bloom_n30000000_h3
>>>>> >   test_cpp_bloom_n30000000_h5
>>>>> >   test_java_bloom_n0_h3
>>>>> >   test_java_bloom_n0_h5
>>>>> >   test_java_bloom_n10000_h3
>>>>> >   test_java_bloom_n10000_h5
>>>>> >   test_java_bloom_n2000000_h3
>>>>> >   test_java_bloom_n2000000_h5
>>>>> >   test_java_bloom_n30000000_h3
>>>>> >
>>>>> >   test_java_bloom_n30000000_h5
>>>>> >
>>>>> > Am I missing something?
>>>>> >
>>>>> > Lee.
>>>>> >
>>>>> > On Fri, Jan 9, 2026 at 4:28 AM tison <[email protected]> wrote:
>>>>> >>
>>>>> >> Hi everyone,
>>>>> >>
>>>>> >> I propose releasing Apache DataSketches Rust version 0.2.0.
>>>>> >>
>>>>> >> Source distribution:
>>>>> >>
>>>>> https://dist.apache.org/repos/dist/dev/datasketches/rust/0.2.0-rc.2/
>>>>> >>
>>>>> >> GitHub tag:
>>>>> >> https://github.com/apache/datasketches-rust/releases/tag/0.2.0-rc.2
>>>>> >>
>>>>> >> Testing (choose one or both):
>>>>> >> - crates.io RC: cargo add [email protected]
>>>>> >> - From source: Download, verify signatures, cargo x test
>>>>> >>
>>>>> >> To verify signatures:
>>>>> >>   curl -O
>>>>> https://dist.apache.org/repos/dist/dev/datasketches/rust/0.2.0-rc.2/apache-datasketches-rust-0.2.0-src.tar.gz
>>>>> >>   curl -O
>>>>> https://dist.apache.org/repos/dist/dev/datasketches/rust/0.2.0-rc.2/apache-datasketches-rust-0.2.0-src.tar.gz.asc
>>>>> >>   gpg --verify apache-datasketches-rust-0.2.0-src.tar.gz.asc
>>>>> >>
>>>>> >> Vote will remain open for at least 72 hours.
>>>>> >>
>>>>> >> [ ] +1 approve
>>>>> >> [ ] +0 no opinion
>>>>> >> [ ] -1 disapprove (and reason why)
>>>>> >>
>>>>> >> Best,
>>>>> >> tison.
>>>>> >>
>>>>> >>
>>>>> ---------------------------------------------------------------------
>>>>> >> To unsubscribe, e-mail: [email protected]
>>>>> >> For additional commands, e-mail: [email protected]
>>>>> >>
>>>>>
>>>>

Reply via email to