Standing-Man commented on code in PR #69: URL: https://github.com/apache/datasketches-rust/pull/69#discussion_r2696562479
########## CONTRIBUTING.md: ########## @@ -32,6 +32,84 @@ cargo version To keep code style consistent, run `cargo x lint --fix` to automatically fix any style issues before committing your changes. +## Build and Test + +We recommend using `cargo x` as a single entrypoint (provided by the workspace `xtask` crate). This repo defines the `cargo x` alias in `.cargo/config.toml`, which maps to `cargo run --package x -- ...`. + +Build: + +```shell +cargo build --workspace +``` + +Test: + +```shell +cargo x test +# or +cargo test --workspace --no-default-features +``` + +Lint: + +```shell +cargo x lint +``` + +## Manual workflow (without xtask) Review Comment: Hi @PsiACE and @tisonkun, Why do we need the manual workflow part? Why not use xtask uniformly for building, testing, and linting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
