tisonkun opened a new issue, #718:
URL: https://github.com/apache/datasketches-java/issues/718

   Currently, the signature looks like:
   
   ```java
     /**
      * @param a the array to sort
      * @param l points AT the leftmost element, i.e., inclusive.
      * @param r points AT the rightmost element, i.e., inclusive.
      */
     static void introspectiveInsertionSort(final int[] a, final int l, final 
int r) {
     }
   ```
   
   But in every function call, `l = 0` and `r = a.length - 1`.
   
   I'm considering to pass only `int[] a` as the param and calculate l, r 
inside. This reduces the learning burden to understand the code.
   
   @AlexanderSaydakov Similarly, the C++ impl has:
   
   ```cpp
   template<typename A>
   void u32_table<A>::introspective_insertion_sort(uint32_t* a, size_t l, 
size_t r) { // r points past the rightmost element
   }
   ```
   
   ... where `l = 0` and `r = a.size()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to