MrCroxx commented on PR #71: URL: https://github.com/apache/datasketches-rust/pull/71#issuecomment-3776666065
> > the sketch array has signed values > > @PsiACE @MrCroxx I'm considering to generify `CountMinSketch` to accept `T: IntNumber` and only implement halve/decay for unsigned versions. > > This should be the same as [cmsketch](https://docs.rs/cmsketch), which implements only for unsigned values. > > cc @c-dickens does it make sense to have this generic design? > > ref - [apache/datasketches-cpp/milestone/1](https://github.com/apache/datasketches-cpp/milestone/1) Sounds good to my use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
