tisonkun commented on PR #75: URL: https://github.com/apache/datasketches-rust/pull/75#issuecomment-3827144239
I'm going to megre this patch recently and continue on the serde(compression) part. But this patch is ported manually so I'd like more eyes on concrete code, to avoid mistakes like https://github.com/apache/datasketches-rust/pull/63 Also, it takes about 3 seconds to accumulate 100M distinct values in my local dev with release profile. Many of the time are spent on hashing. I hope we can make some baseline and improve the performance a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
