Copilot commented on code in PR #81: URL: https://github.com/apache/datasketches-rust/pull/81#discussion_r2750479427
########## CHANGELOG.md: ########## @@ -7,12 +7,14 @@ All significant changes to this project will be documented in this file. ### Breaking changes * `CountMinSketch` now has a type parameter for the count type. Possible values are `u8` to `u64` and `i8` to `i64`. +* `HllUnion::get_result` is renamed to `HllUnion::to_sketch`. ### New features * `CountMinSketch` with unsigned values now supports `halve` and `decay` operations. +* `CpcSketch` and `CpcUnion` is now available for cardinality estimation. Review Comment: Subject-verb agreement error: Since "CpcSketch and CpcUnion" is a plural subject (two items), the verb should be "are" instead of "is". ```suggestion * `CpcSketch` and `CpcUnion` are now available for cardinality estimation. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
