tisonkun opened a new pull request, #85: URL: https://github.com/apache/datasketches-rust/pull/85
This follows https://github.com/apache/datasketches-rust/pull/84#discussion_r2764759992. I have two questions: 1. Shall we check the seed when creating sketches? Currently, we check only when serde, thus if the sketch never serde, we don't have this guard. Not sure if check earilier helps. 2. Since the serialized seed_hash occurs in the middle of the final result, I'm curious about the format of earlier serialized sketches. Do they have a placeholder 2-byte buffer that is fulfilled in later version? If we panic always when the computed seed = 0, then all those old snapshots cannot be read. cc @ZENOTME @leerho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
