tisonkun commented on issue #90: URL: https://github.com/apache/datasketches-rust/issues/90#issuecomment-3897276325
@pmcgleenon either is OK for me. To reduce review burden, I'd prefer a version as closed to the C++ impl as possible. The patch would better note any significant changes from the C++ or other referenced impl. Then we can use that as a starting point to make more changes. You can take the commit history of CpcSketch as an example. And yes, keep the serde impl compatible with other impl is significant since datasketches work hard to make all sketches interoperable among languages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
