notfilippo opened a new issue, #96: URL: https://github.com/apache/datasketches-rust/issues/96
We currently define sketch-specific value traits (`DensityValue` from #62, [`CountMinValue`](https://github.com/notfilippo/datasketches-rust/blob/539fd1a1f17510303a6c14335ed5c4400bba2e78/datasketches/src/countmin/value.rs#L26)) that expose only the operations needed by each sketch. There is growing overlap between them. For example, `DensityValue` is implemented for `f32`/`f64`, and we sometimes convert to `f64` for operations. ## Proposal Evaluate replacing these traits with appropriate traits from [num-traits](https://github.com/rust-num/num-traits) (e.g., `Float`) to: - Reduce duplication - Reuse well-known numeric abstractions - Avoid unnecessary conversions This is exploratory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
