tisonkun commented on code in PR #77: URL: https://github.com/apache/datasketches-rust/pull/77#discussion_r2808587584
########## datasketches/src/hash/mod.rs: ########## @@ -35,7 +35,8 @@ pub(crate) use self::xxhash::XxHash64; /// and seed are identical for both sketches, otherwise the assumed 1:1 relationship between the /// original source key value and the hashed bit string would be violated. Once you have developed /// a history of stored sketches you are stuck with it. -pub(crate) const DEFAULT_UPDATE_SEED: u64 = 9001; +/// The default seed used for hashing. +pub const DEFAULT_UPDATE_SEED: u64 = 9001; Review Comment: The `hash` mod is `pub(crate)`. I'd prefer to keep this item `pub(crate)` as well. At least please avoid include unrelated change in such a large PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
