leerho commented on PR #92: URL: https://github.com/apache/datasketches-rust/pull/92#issuecomment-4743982760
WRT Windows and CRLF issues. I noticed that there is no .gitattributes file in ds-cpp. I ran into similar issues recently when refactoring ds-memory. It turns out all the major modern OSs can correctly process text files with just LF "\n" line endings. So structuring the .gitattributes file to force LF endings for all text type files fixed the problem and it works for Ubuntu, MacOS, and Windows. See this .[gitattributes](https://github.com/apache/datasketches-memory/blob/main/.gitattributes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
