+1 (binding)
I apologize for my delay in addressing this.
- All the traditional checks passed:
- Downloading source, build OK
- signature, checksum OK
- README, LICENSE OK
- All the tests passed (no fatal errors)
However, in scanning the test results I noticed 140 "file not found"
errors related to missing *.sk test files.
I discovered that the "serialization_test_data" directory was almost empty.
The breakout of these 140 missing *.sk files:
- 93 missing java.sk
- 9 missing go.sk
- 38 missing cpp.sk
I copied into the "serialization_test_data" directory:
- 270 java.sk files (fresh generation)
- 30 go.sk files (not necessarily the latest)
- 221 cpp.sk files (not necessarily the latest)
And ran the Go test again. This time there were only 9 missing "go.sk"
files.
This allows us to compute a very simple metric regarding the current status
of the Go library:
- SK files not read:
- 270 - 93 = 177 java.sk
- 221 - 38 = 183 cpp.sk
- 30 - 9 = 21 go.sk
This could be due to sketches that have not yet been implemented in Go or
because tests for the specific *.sk files have not yet been written.
This is perfectly understandable as the Go library is still in development.
All in all, this is a very positive result and the folks contributing to
the Go library should feel good about it!
Lee.
On Sat, Jun 20, 2026 at 12:25 AM Hyeonho Kim <[email protected]> wrote:
> Hi all,
>
> Just a friendly reminder that the vote for Apache DataSketches Go v0.2.0
> RC2 is still open.
>
> So far, we have received one +1 vote. We still need additional votes to
> complete the release process, so your review would be greatly appreciated.
>
> Thanks,
> Hyeonho Kim
>
> On Sun, Jun 14, 2026 at 3:41 AM Pierre Lacave <[email protected]> wrote:
>
>>
>> +1 (binding)
>>
>> Verified RC2 on macOS/arm64 (Go 1.25.7):
>> - shasum -a 512 -c: OK. GPG: Good signature, HyeonhoKim <
>> [email protected]> (key 19272095A6D67D98), present in KEYS.
>> - Source byte-identical to git tag v0.2.0-rc2 (commit 9ba7c12);
>> - LICENSE Apache-2.0 (binding terms verbatim), NOTICE correct (Copyright
>> 2023-2026 ASF), no vendored deps, all 230 .go files carry the ASF header.
>> - go test -v -count=1 ./...: 18 packages ok, 2185 PASS / 156 SKIP / 0
>> FAIL. go vet and go build clean. go get
>> github.com/apache/[email protected] resolves.
>>
>> Thanks
>>
>> On 2026/06/06 08:26:34 Hyeonho Kim wrote:
>> > Hi all!
>> >
>> >
>> > I would like to propose releasing Apache DataSketches Go v0.2.0.
>> >
>> >
>> >
>> > - Source Distribution:
>> >
>> > https://dist.apache.org/repos/dist/dev/datasketches/go/0.2.0-RC2/
>> >
>> >
>> > - Github tag:
>> >
>> > https://github.com/apache/datasketches-go/releases/tag/v0.2.0-rc2
>> >
>> >
>> >
>> > - Download the source distribution, signature, checksum, and KEYS file:
>> >
>> >
>> > curl -O
>> >
>> https://dist.apache.org/repos/dist/dev/datasketches/go/0.2.0-RC2/apache-datasketches-go-0.2.0-src.tar.gz
>> >
>> > curl -O
>> >
>> https://dist.apache.org/repos/dist/dev/datasketches/go/0.2.0-RC2/apache-datasketches-go-0.2.0-src.tar.gz.asc
>> >
>> > curl -O
>> >
>> https://dist.apache.org/repos/dist/dev/datasketches/go/0.2.0-RC2/apache-datasketches-go-0.2.0-src.tar.gz.sha512
>> >
>> > curl -O https://dist.apache.org/repos/dist/release/datasketches/KEYS
>> >
>> >
>> >
>> > - Import the KEYS file and verify the signature:
>> >
>> >
>> > gpg --import KEYS
>> > gpg --verify apache-datasketches-go-0.2.0-src.tar.gz.asc
>> > apache-datasketches-go-0.2.0-src.tar.gz
>> >
>> >
>> >
>> > - Verify the checksum:
>> >
>> >
>> > shasum -a 512 -c apache-datasketches-go-0.2.0-src.tar.gz.sha512
>> >
>> >
>> >
>> > - Run tests from the extracted source distribution:
>> >
>> >
>> > tar -xzf apache-datasketches-go-0.2.0-src.tar.gz
>> > cd apache-datasketches-go-0.2.0
>> >
>> > go test -v -count=1 ./...
>> >
>> >
>> >
>> > Alternatively, if you have a container runtime such as Docker:
>> >
>> >
>> > ./build/run-docker-test.sh
>> >
>> >
>> >
>> > The release candidate can also be tested as a Go module:
>> >
>> >
>> > go get github.com/apache/[email protected]
>> >
>> >
>> >
>> >
>> > The vote will remain open for at least 72 hours.
>> >
>> >
>> > [ ] +1 Approve
>> >
>> > [ ] 0 No opinion
>> >
>> > [ ] -1 Do not release (please explain why)
>> >
>> >
>> > Best regards,
>> >
>> > Hyeonho Kim
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
