tisonkun commented on PR #140: URL: https://github.com/apache/datasketches-rust/pull/140#issuecomment-4810190683
> `entry_ref` https://docs.rs/hashbrown/latest/hashbrown/struct.HashMap.html#method.entry_ref This sounds like a good interface to follow. You may follow its naming and trait-bound conventions, and I'll give a review once you get all updates ready. I'm fine with ToOwned now. But the API name needs some considerations, `update_borrowed` doesn't sound like a good name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
