k3dom commented on PR #144: URL: https://github.com/apache/datasketches-rust/pull/144#issuecomment-4879543363
Nice, LGTM! Two small thoughts: - `active_entries()` could probably be a lazy iterator `impl Iterator<Item = (&T, u64)> + '_` instead of collecting `Vec<(&T, u64)>` which would make it totally allocation-free, not sure if it would be always faster though for very large maps. - Would probably also make sense to update `frequent_items_with_threshold` as a follow-up because here we still clone every qualifying item into owned `Row`'s before the caller can filter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
