tisonkun commented on PR #145: URL: https://github.com/apache/datasketches-rust/pull/145#issuecomment-5010707382
There is one more pending issue: the two traits we made public in common are looking a bit strange right now. If you want to make them sealed or handle them differently, we probably need to refactor the tests in union.rs. It feels very awkward to implement sealed traits for a struct inside the test module itself. We should take a step back and look at the overall scope of these two traits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
