tisonkun commented on code in PR #147: URL: https://github.com/apache/datasketches-rust/pull/147#discussion_r3608068362
########## datasketches/src/theta/mod.rs: ########## @@ -46,7 +46,17 @@ mod raw_hash_table; mod serialization; mod sketch; +// These helpers are re-exported only for Tuple hash-table tests; production code uses the shared +// raw table directly. +#[cfg(all(feature = "tuple", test))] +pub(crate) use self::hash_table::starting_sub_multiple; +#[cfg(all(feature = "tuple", test))] +pub(crate) use self::hash_table::starting_theta_from_sampling_probability; pub use self::intersection::ThetaIntersection; +#[cfg(feature = "tuple")] +pub(crate) use self::raw_hash_table::RawHashTable; +#[cfg(feature = "tuple")] +pub(crate) use self::raw_hash_table::RawHashTableEntry; Review Comment: #145 moves these symbols to `thetacommon`, we'd avoid these `pub(crate) use` now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
