ZENOTME commented on code in PR #153: URL: https://github.com/apache/datasketches-rust/pull/153#discussion_r3645208523
########## datasketches/src/tuple/policy.rs: ########## @@ -26,6 +26,22 @@ use std::marker::PhantomData; use std::ops::AddAssign; +use crate::thetacommon::union::RawThetaUnionPolicy; +use crate::tuple::hash_table::TupleEntry; + +/// Adapts a [`SummaryCombinePolicy`] to the raw union's entry-merge policy. +#[derive(Debug)] +pub(crate) struct CombinePolicyAdapter<P>(pub(crate) P); Review Comment: Can it be a internal adpater type in [union.rs](https://github.com/apache/datasketches-rust/pull/153/changes#diff-f3568728db442efe8852306fd065409eb9c4286921170ef66c3cde0b9d452be4) ########## datasketches/src/thetacommon/mod.rs: ########## @@ -20,6 +20,7 @@ pub(crate) mod binomial_bounds; pub(crate) mod constants; pub(crate) mod hash_table; +#[cfg(any(feature = "theta", feature = "tuple"))] Review Comment: Maybe we need cfg at thetacommon level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
