jaideeppyne commented on PR #183: URL: https://github.com/apache/datasketches-rust/pull/183#issuecomment-5198341578
Thanks — updated in 6b193ad. `check_seed_hash` now accepts an error-producing closure over `(expected, actual)`, so each caller retains control of its error contract. In particular, the CPC path still uses its prior explicit `Error::new(ErrorKind::InvalidData, ...)` form, while the deserialization paths retain `Error::deserial(...)`; the helper only owns the equality check. This also keeps the mismatch path to one seed-hash computation. Validation after the change: - `cargo x test` — passed - `cargo +nightly clippy --tests --all-features --all-targets --workspace -- -D warnings` — passed - `cargo +nightly fmt --all --check` — passed - `RUSTDOCFLAGS="--cfg docsrs -D warnings" cargo +nightly doc --package datasketches --all-features --no-deps` — passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
