tisonkun commented on code in PR #196: URL: https://github.com/apache/datasketches-rust/pull/196#discussion_r3754830780
########## datasketches/src/hll/union.rs: ########## @@ -45,6 +45,12 @@ use crate::hll::mode::Mode; /// the union of all input sketches. It automatically handles sketches with /// different configurations and modes. /// +/// Coupon-mode inputs are replayed into the current gadget without reducing its `lg_k`. An +/// array-mode input with a smaller `lg_k` reduces the gadget to that value; larger array inputs are +/// downsampled to the gadget's current configuration. Once reduced, the effective `lg_k` remains +/// lower until [`reset`](Self::reset), so estimates and bounds reflect the reduced register count. +/// The requested [`HllType`] changes only the result representation, not its statistical accuracy. +/// Review Comment: Is `Coupon-mode` and `array-mode` user facing concept? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
