tisonkun commented on issue #212: URL: https://github.com/apache/datasketches-rust/issues/212#issuecomment-5447854830
Thank @zhangxinyao88 for https://github.com/apache/datasketches-rust/pull/232. This hints to me about one more issue: In Rust, there is a loose contract: 1. If a type implements both `FromStr` and `Display`, the following code snippet should pass: ```rust assert_eq!(o, FromStr::from_str(o.to_string())) ``` 2. The result of `Display` should be stable within one compatible version range. However, the current printing format looks like: ``` HLL Sketch Summary: lg config k : 12 target type : Hll8 current mode : List lower bound : 0 estimate : 0 upper bound : 0 ``` Seems more like a changable diagnostic report. cc @leerho what is the design principle of these formats in datasketches-java. Are they mainly for debugging or diagnostics? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
