tisonkun opened a new pull request, #242:
URL: https://github.com/apache/datasketches-rust/pull/242

   ## Summary
   
   - remove `ReqUnion`, which only delegated to an inner `ReqSketch`
   - keep `ReqSketch::merge` as the REQ aggregation API and add a usage example
   - update the README and unreleased changelog to describe merging without a 
separate union type
   
   ## Rationale
   
   The Java, C++, Python, and Go REQ implementations expose aggregation 
directly through the sketch's `merge` method. Unlike CPC, HLL, and Theta 
unions, `ReqUnion` maintained no distinct accumulator state or 
configuration-reconciliation behavior, and `to_sketch` cloned the wrapped 
sketch.
   
   REQ has not been included in a release yet, so the discarded intermediate 
API does not require a migration entry. This change intentionally leaves the 
existing `ReqSketch::merge` compatibility rules, including mixed-`k` behavior, 
unchanged.
   
   ## Testing
   
   - `cargo x check`
   - `cargo x test`
   - `cargo x lint`
   
   Closes #217.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to