v0id-X commented on PR #271: URL: https://github.com/apache/datasketches-rust/pull/271#issuecomment-5519275636
All review comments addressed and updated: - Removed the outdated guarantee disclaimer on `BloomFilter`. - Moved mutation/inversion details from `BloomFilter::invert`'s doc to `BloomFilterInvertedView`'s struct-level documentation. - Removed the `into_filter` alias in favor of symmetrical `invert(self) -> BloomFilter`. - Removed `as_filter` to preserve view encapsulation. - Aligned `CHANGELOG.md` under `### Breaking changes` and `### New features` per `CONTRIBUTING.md`. - Uncommented the inverted view doctest example in `bloom/mod.rs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
