> cargo x lint failed on my machine because xtask auto-installs taplo-cli via an unpinned cargo install taplo-cli when it isn't already on PATH (xtask/src/main.rs, ensure_installed). > On a clean environment this now pulls in taplo-cli transitive dependencies (icu_*, time) that require rustc 1.88, while rustc is pinned to 1.86.0 in rust-toolchain.toml.
Thanks for your report. I'll open an issue to improve this experience. Best, tison. Best, tison. Pierre Lacave <[email protected]> 于2026年9月3日周四 15:46写道： > +1 (binding) > > Verified: > - Downloaded the archive, signature, and checksum from > https://dist.apache.org/repos/dist/dev/datasketches/rust/0.5.0-rc.1/ > - SHA-512 checksum matches (shasum -a 512 --check: OK) > - GPG signature is valid and made by fingerprint > 8B374472FAD328E17F479863B379691FC6E298DD, which is present in the > DataSketches KEYS file with a [email protected] UID > - Archive contains LICENSE, NOTICE, Cargo.toml, Cargo.lock, CHANGELOG.md, > and no unexpected files (e.g. no embedded .git) > - Cargo.toml version and ## v0.5.0 CHANGELOG heading match the > proposed release version > - cargo package --list / cargo publish --dry-run -p datasketches > succeed (101 files, 1.9MiB) > - cargo x prepare-testdata, cargo x check (all feature > combinations), and cargo x test all pass with zero failures > across every module > > > Non-blocking: > cargo x lint failed on my machine because xtask auto-installs taplo-cli > via an unpinned cargo install taplo-cli when it isn't already on PATH > (xtask/src/main.rs, > ensure_installed). > On a clean environment this now pulls in taplo-cli transitive dependencies > (icu_*, time) that require rustc 1.88, while rustc is pinned to 1.86.0 in > rust-toolchain.toml. > > Thanks > > On 2026/09/01 05:48:06 AriesDevil wrote: > > Hi all, > > > > Thanks for the reminder. For completeness, here are the checks behind my > +1 vote: > > > > - Downloaded the source artifact from the ASF dist/dev directory and > verified its SHA-512 checksum. > > > > - Verified the GPG signature against the project KEYS file and confirmed > the signing-key fingerprint. > > > > - Inspected the source archive, including LICENSE, NOTICE, the expected > 0.5.0 version, and the absence of unexpected binary files. > > > > - Ran cargo package --list -p datasketches and cargo publish --dry-run > --locked -p datasketches. > > > > - Ran cargo x prepare-testdata, cargo x lint, cargo x check, and cargo x > test. > > > > All checks passed, and I found no release-blocking issues. > > > > My vote remains +1 (non-binding). > > > > On 2026/09/01 01:51:30 tison wrote: > > > Hi everyone, > > > > > > I propose releasing Apache DataSketches Rust version 0.5.0. > > > > > > The release candidate is based on commit: > > > 77f5652016b3859c23b60c5b8b9e94578ef484f0 > > > > > > Source distribution: > > > https://dist.apache.org/repos/dist/dev/datasketches/rust/0.5.0-rc.1/ > > > > > > Artifact: > > > apache-datasketches-rust-0.5.0-src.zip > > > > > > Git tag: > > > https://github.com/apache/datasketches-rust/tree/0.5.0-rc.1 > > > > > > Changelog: > > > > https://github.com/apache/datasketches-rust/blob/0.5.0-rc.1/CHANGELOG.md > > > > > > Signing key fingerprint: > > > 8B374472FAD328E17F479863B379691FC6E298DD > > > > > > SHA-512: > > > > e4e2be3918093fa7ce561f2f686364b446cbdb24497a9d0db89ae77fcb1c12dc9e0ecd36c99857efbeabfba0860b96764b9b6bebb86b346ccb9790e7ec25bc97 > > > apache-datasketches-rust-0.5.0-src.zip > > > > > > Testing: > > > - crates.io RC: cargo add [email protected] > > > - source: verify the checksum and signature, then run the release > checks > > > > > > Verification: > > > shasum -a 512 --check apache-datasketches-rust-0.5.0-src.zip.sha512 > > > gpg --verify apache-datasketches-rust-0.5.0-src.zip.asc > > > apache-datasketches-rust-0.5.0-src.zip > > > > > > The vote will remain open for at least 72 hours, until > > > 2026-09-04 06:00 UTC. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove, with a reason > > > > > > Thanks, > > > tison > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
