jaideeppyne opened a new pull request, #769:
URL: https://github.com/apache/datasketches-java/pull/769

   ## Summary
   
   - Copy the stored min/max from the other digest in `TDigestDouble.merge` 
before compressing the combined centroid list.
   - Add a regression that heapifies an image whose stored min/max sit strictly 
outside the extreme centroid means, then merges it into an empty digest and 
into a non-empty one.
   
   ## Why
   
   `merge` previously re-derived extrema from the extreme centroid means. That 
is exact only when those centroids have unit weight. Deserialized images (and 
the reference implementation format) can have weighted tails, so min/max 
drifted inward and rank/quantile tail interpolation used the wrong endpoints.
   
   Same defect as apache/datasketches-rust#277. Independent of #767.
   
   ## Validation
   
   - `TDigestDoubleTest#mergePreservesDeserializedMinMaxWithWeightedTails`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to