jaideeppyne opened a new pull request, #279: URL: https://github.com/apache/datasketches-rust/pull/279
## Summary - Update `TDigestMut::merge` to take `self.min`/`self.max` from `other.min`/`other.max` before compression. - Compression only sees centroid means, which can differ from the stored extrema (e.g. after deserialization with heavy extreme centroids), so merge previously drifted `min_value()`/`max_value()` and degraded tail rank/quantile interpolation. - Add a regression that merges digests whose stored min/max differ from extreme centroid means. - Document the fix in the changelog. Fixes #277 ## Note for reviewers This branch also touches `.github/workflows/ci.yml` only because the fork was behind `main` and the OAuth token lacks the `workflow` scope needed to push a tip that restores the current upstream workflow file. Please treat that hunk as unrelated fork-sync noise; the intended change is the three non-workflow files. Happy to refresh the branch once `workflow` scope is available. ## Validation - Regression constructed from the existing `deserialize_with_centroids` helper (empty digest merge + two-way merge with drifted extrema). - Diff against `main` for the t-digest sources is the two-line min/max update plus the new test and changelog line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
