jaideeppyne opened a new pull request, #774: URL: https://github.com/apache/datasketches-java/pull/774
Closes #773. Historical C++ theta single-item images may omit the optional single-item flag. Java accepts these images, but `PreambleUtil.preambleToString()` previously derived the implied count from that flag and displayed `CurrentCount: 0`. This change derives the one-preamble-long count from the authoritative empty flag while continuing to display the serialized single-item flag unchanged. The regression test clears only the flag on a valid single-item image and verifies: - `SINGLE_ITEM: false` accurately reflects the historical bytes - `CurrentCount: 1` accurately reflects the retained item Validation: - `mvn -t /private/tmp/jdk25-toolchains.xml -Dtest=org.apache.datasketches.theta.PreambleUtilTest test` (8 tests) - `mvn -t /private/tmp/jdk25-toolchains.xml test` (2,287 tests) - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
