tisonkun commented on code in PR #285:
URL: https://github.com/apache/datasketches-rust/pull/285#discussion_r4172359768
##########
datasketches/src/countmin/value.rs:
##########
@@ -39,7 +39,9 @@ mod private {
fn checked_abs(self) -> Option<Self>;
fn checked_add(self, other: Self) -> Option<Self>;
- fn scale(self, factor: f64) -> Self;
+ /// Scales a nonnegative weight by a factor in `(0, 1]`, truncating
toward zero.
+ /// Signed sketches scale only their total absolute weight.
+ fn scale_nonnegative(self, factor: f64) -> Self;
Review Comment:
```suggestion
fn scale_nonnegative(self, factor: f64) -> Self;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
