leerho opened a new pull request, #13:
URL: https://github.com/apache/datasketches-tck/pull/13
Updates the C++ and Java snapshot pins to the current upstream default
branches and regenerates their snapshots. Also keeps `.sk` files tracked when a
contributor's global gitignore excludes them.
## Commits
- **Track `.sk` snapshots even when a global gitignore excludes them.** Adds
`!*.sk` to `.gitignore`.
- **Java `3a1bf7f` → `059b5a9`** (merge of apache/datasketches-java#774).
Deterministic changes:
- HLL_6 and HLL_8 compact images set the compact flag (java#761).
- Empty tuple and AoS compact images write a zero seed hash.
- Adds `frequent_long_purged` and `frequent_string_purged` (java#770).
- **C++ `fe0261a` → `16d4ea6`** (current `master`). Deterministic changes:
- Single-item compact theta images set the single-item flag (cpp#526).
- Adds `frequent_long_purged` and `frequent_string_purged` (cpp#529).
- Removes the 27 `aos_*_cpp.sk` snapshots. The C++ array-of-strings tuple
sketch was reverted (apache/datasketches-cpp#537) because its key hashing is
incompatible with Java (apache/datasketches-cpp#533).
All other modified files are probabilistic snapshots.
## Not included: Go
Go `main` can't currently generate its theta and tuple snapshots. A lint
cleanup (go#181) made the generators fail on `ErrHashExceedsTheta`, which
`Update` returns by design. The fix is in a separate datasketches-go PR. The Go
pin stays at `757a485` until that lands.
## Verification
- `mise run tck -- snapshots update cpp master` and `snapshots update java
main`
- `mise run tck -- snapshots update all`: C++ and Java already match their
latest commits
- `mise run check`
The PRs for #11 and #12 are stacked on this one.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
