leerho opened a new pull request, #193: URL: https://github.com/apache/datasketches-go/pull/193
`make generate-go-snapshots` fails on `main` for the theta, tuple, array-of-numbers, and array-of-strings sketches: ``` Error: Received unexpected error: hash exceeds theta Test: TestGenerateGoSnapshots_ThetaSketch/theta_sketch_generate ``` ## Cause The lint cleanup in 26260d0 (#181) wrapped the generators' `Update*` calls in `assert.NoError`. Once a sketch is in estimation mode, or when `p < 1`, `Update` returns `ErrHashExceedsTheta` for keys it skips by design. The generators only run when `DSKETCH_TEST_GENERATE_GO` is set, so CI didn't catch it. I confirmed `757a485` generates cleanly and `26260d0` doesn't. ## Fix The generators now use the existing `assertUpdate` helper. It accepts `ErrHashExceedsTheta`, and the other theta and tuple tests already use it. This is a test-only change, limited to the `TestGenerateGoSnapshots*` functions. ## Verification - `make generate-go-snapshots` passes. - `go test ./...` passes. - `golangci-lint run ./theta/... ./tuple/...` reports 0 issues. This blocks updating the Go snapshots in datasketches-tck (apache/datasketches-tck#13). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
