leerho opened a new pull request, #775: URL: https://github.com/apache/datasketches-java/pull/775
Updates `tools/download_serialization_test_data.sh` for the new TCK layout and moves its pin to the current TCK `main`. ## Changes - **New TCK layout.** The TCK moved its snapshots from `serialization/<lang>/snapshots/` to `serialization_test_data/<lang>_generated_files/` (apache/datasketches-tck#14), the same layout this repository uses. The script now matches the new archive paths and uses `--strip-components=3` instead of `4`. - **Pin.** `TCK_REVISION` moves from `d363b12` (July) to `e748b0a`, the current TCK `main`. - **`serde-compat.yml`.** The Java matrix entry passed `java` to the download script, which only accepts `cpp` and `go`, so that job failed. The `check_java_files` profile generates its own snapshots before checking them, so the download step is now skipped for that entry. ## Verification - With no arguments, the script extracts 202 C++ and 253 Go snapshots from TCK `e748b0a`. - `mvn test -P check_go_files` passes. - `mvn test -P check_java_files` passes. - `mvn test -P check_cpp_files` has **one known failure:** `AodSketchCrossLanguageTest.checkCpp`, "Incompatible Seed Hashes. 0, 93cc". ## About the known failure It's a real C++/Java incompatibility that the old pin hid. It is not caused by this change. - apache/datasketches-cpp#518 made empty compact theta and tuple sketches write a seed hash of `0`, to match Java's `EmptyCompactSketch`. In C++, array-of-doubles (AoD) is built on the generic tuple sketch, so empty AoD sketches now write `0` too. - Java's AoD sketches write the real seed hash for an empty sketch, and their readers reject `0`. - The TCK picked up that C++ change on Sep 1, after the old pin `d363b12`, so this test never saw it until now. Standard `mvn clean test` is unaffected. The failure only shows up when the cross-language profiles run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
