tisonkun commented on code in PR #294:
URL: https://github.com/apache/datasketches-rust/pull/294#discussion_r4221808773
##########
datasketches/src/hll/sketch.rs:
##########
@@ -232,6 +232,36 @@ impl HllSketch {
}
}
+ /// Returns the cardinality estimate using the composite estimator.
+ ///
+ /// The estimate is derived only from the sketch's registers, so it does
not depend on the
+ /// order in which values were inserted. This can be less accurate than
+ /// [`estimate`](Self::estimate); use it to compare estimates across
sketches that saw the
+ /// same values in different orders. This method does not modify the
sketch.
Review Comment:
```suggestion
/// Returns the current cardinality estimate that never depends on
/// the order in which values were inserted.
///
/// This can be less accurate than [`estimate`](Self::estimate).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
