tisonkun opened a new pull request, #301: URL: https://github.com/apache/datasketches-rust/pull/301
Follow-up to https://github.com/apache/datasketches-rust/pull/300#discussion_r4357033830. ## Summary - Introduce a private `BucketCount` to keep the bucket count and its precomputed remainder multiplier together. - Move power-of-two masking and exact remainder reduction behind `BucketCount::index`. - Preserve the public API, serialized bytes, and exact bucket assignment. ## Trade-off On the current 64-bit target, nesting the `u32` count and `u128` multiplier increases `CountMinSketch` from 96 to 112 bytes because the outer type cannot reuse the nested type's tail padding. `estimated_size()` therefore increases by 16 bytes per sketch, and the existing size test reflects that change. ## Validation - `cargo x check` - `cargo x test` - `cargo x lint` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
