ziyziy89 commented on PR #777: URL: https://github.com/apache/datasketches-java/pull/777#issuecomment-6409677054
Pushed 0ec3cb5, which adds the lgCur > lgMax check to getInstance(String) and the same two checks on the lgCurMapSize and lgMaxMapSize bytes in getInstance(MemorySegment). On the binary side they sit straight after the existing preamble checks, so they run before either the empty-image return or the sketch constructor. That should line up with check_size() in the C++ version. There are three new tests (checkStringDeserMapLengthExceedsMax, checkSegDeserLgCurMapSizeTooSmall, checkSegDeserLgCurMapSizeExceedsLgMax), all with timeOut like the earlier ones. Frequencies tests come out at 66 passing now and verify is clean. Fine with it sitting as a draft until the related work lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
