leerho commented on PR #779: URL: https://github.com/apache/datasketches-java/pull/779#issuecomment-6432879603
Thank you for submitting the requested changes. But there is a remaining problem with the Javadocs: The new class Javadoc says the rule “makes the result of a merge independent of the order of the input.” That overstates the solution in the same way that was corrected in [apache/datasketches-java#780](https://github.com/apache/datasketches-java/issues/780). What we need is more clarity: something like: "...ordered by mean ascending and then, for equal means, by weight ascending. This makes each merge independent of how the centroids are arranged before sorting, so that the same sequence of updates and merges always produces the same sketch. It does not make the sketch independent of the order of the input values." If you could please make this clarification, I will approve. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
