tisonkun opened a new pull request, #311: URL: https://github.com/apache/datasketches-rust/pull/311
Follow-up to #306. Remove the single-hash dispatch from `BloomFilter::insert` so every configuration uses the same unconditional bit-setting loop. `contains_and_insert` retains conditional writes. Bit positions, bit counts, and serialized bytes are unchanged. Clarify that `num_hashes` counts hash-derived bit positions per item: two base hashes generate `k` probes, and positions may repeat. The public API names and serialized format remain unchanged. Validation: `cargo x check` and `cargo x test` (777 passed). Full `cargo x lint` also passed in a clean source copy containing the same changes; existing generated `target/package` manifests in the checkout fail Taplo formatting. The fresh performance matrix and its workload-specific regressions will be posted in a separate comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
