daescha opened a new pull request, #204: URL: https://github.com/apache/datasketches-go/pull/204
`extractCommonHll` copies the register bytes into the array the sketch allocates instead of keeping a sub-slice of the input. - A decoded HLL4/6/8 sketch then stays valid after the caller reuses or changes its input buffer, and updates to the sketch do not write into that buffer. - `TestDeserializeCopiesRegisters` zeroes the input after decoding and checks that the sketch serializes unchanged. - A truncated register array needs the length check from #203 to return an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
