proost commented on code in PR #785:
URL: https://github.com/apache/datasketches-java/pull/785#discussion_r4430968387
##########
src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java:
##########
@@ -415,10 +440,16 @@ public CompactTupleSketch<S> compact() {
* @deprecated As of 3.0.0, serializing an UpdatableTupleSketch is
deprecated.
* This capability will be removed in a future release.
* Serializing a CompactTupleSketch is not deprecated.
+ * @throws SketchesStateException if this sketch was created with a custom
seed,
+ * because this serialized form has no seed hash. Use
compact().toByteArray() instead.
*/
@Deprecated
@Override
public byte[] toByteArray() {
+ if (seedHash_ != Util.DEFAULT_SEED_HASH) {
Review Comment:
I think comparing with seed is more meaningful and correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
