tisonkun opened a new pull request, #325: URL: https://github.com/apache/datasketches-rust/pull/325
XOR construction repeats fingerprint allocation and assignment for each width, while the benchmark matrix emphasizes adjacent cardinalities and a specially selected retry input. Share fingerprint allocation with assignment, centralize the validated 32-bit range conversion, and remove the builder forwarding method used only to expose an attempt limit to tests. Keep retry, order-independence, empty-filter, and compatibility coverage at their existing behavior boundaries while removing overlapping assertions and tests. Replace the matched-retry performance matrix with small, shard-sized, and large builds; retain independent-filter batches and imported-filter queries. Deduplicating comparisons now use repeated values and include the sorting and deduplication required by xorf's caller, so both sides perform equivalent work. Validation: `cargo x check`, `cargo x test` (815 tests), `cargo x lint` (identical clean source copy), and `cargo x bench -- --test` (246 implementation/workload combinations). Optimized before/after spot checks show similar construction and query timings; this change does not claim a new broad speedup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
