tisonkun opened a new pull request, #795: URL: https://github.com/apache/datasketches-java/pull/795
XOR membership queries need the construction seed, segment layout, and fingerprints, but not the number of input hashes. Requiring a count in the serialized image prevents importing those fields without inventing metadata. [xorf](https://github.com/ayazhafiz/xorf/blob/0.13.0/src/xor8.rs) and [FastFilter C](https://github.com/FastFilter/xor_singleheader/blob/master/include/xorfilter.h) also omit the count. This is a representation choice: FastFilter Java retains its input size to derive the layout. Remove the finished filter's count and `getNumItems()`, `isEmpty()`, and `getBitsPerItem()`. Callers measuring bits per input can divide the footprint by their known input count. The builder still tracks its updates. The XOR format is unreleased. Version 2 reduces the header from 24 to 16 bytes and stores the fingerprint width, segment length, and seed; it rejects version 1. Cross-language readers must adopt the new version together. Validation: `mvn -B clean verify` passes all 2,335 tests, Javadocs, and license checks. XOR tests cover heapify/wrap round trips, reference fingerprints, malformed headers, and truncated images. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
