Waterpine commented on code in PR #332: URL: https://github.com/apache/datasketches-rust/pull/332#discussion_r4489653573
########## datasketches/src/kll/value.rs: ########## Review Comment: Thanks, makes sense. I've restored `partial_cmp().unwrap()` (b7e4fcf). For the record, it was there for speed rather than to avoid `unwrap()`: the compiler keeps the NaN check and panic branch in every comparison, and on this branch `<`/`>` made `quantile`/`quantiles` take about 19% less time. That part of the gain is gone now, and I've updated the numbers in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
