Greetings,
I have just added a patch and some test data and results to issue
94543 <http://www.openoffice.org/issues/show_bug.cgi?id=94543>. Points
arising ...
(*) I am not satisfied with my analysis of the impact of the change.
For me to make any progress on this, I think I shall have to start
over with {OpenGrok, considering the confusion I got into in my
first attempt at analysis. Perhaps someone here "just knows" that
the change looks right or wrong? Of course, having found the bug
at two places, I have to fear that there is a third place which I
have not found.
(*) "Contributing Patches"
<http://wiki.services.openoffice.org/wiki/Contributing_Patches>
assumes a working copy from cvs. I lack that, so submitted a diff
of from the files that I have. Is this of any use?
(*) Along the way, a couple of things in the cod have raised my
eyebrows a little bit. Are they candidates for fixes?
- The last case the switch structure ending at
connectivity/source/drivers/odbcbase/OTools.cxx line 394 lacks
a break statement.
- Line 248 of the same file assigns a literal constant to
_nColumnSize. I think it would be better to use
SQL_TIMESTAMP_LEN defined at unixODBC/inc/sql.h line 55.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@dba.openoffice.org
For additional commands, e-mail: dev-h...@dba.openoffice.org
