On Wed, 2012-02-15 at 15:49 +0100, [email protected] wrote:
> From: Michal Fojtik <[email protected]>
ACK
One nit:
> @@ -237,7 +237,8 @@ class RHEVMDriver < Deltacloud::BaseDriver
> public_addresses = []
> # First try to get IP address from RHEV-M. This require rhev-agent
> package
> # installed on guest
> - public_addresses << InstanceAddress.new(inst.ip) if inst.ip
> + public_addresses = inst.ips.map { |ip| InstanceAddress.new(ip, :type =>
> :ipv4) } unless inst.ips.empty?
The 'unless' check is not needed (and then you can drop the
initialization of public_addresses to [], too)
David
