[
https://issues.apache.org/jira/browse/DTACLOUD-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222391#comment-13222391
]
Michal Fojtik commented on DTACLOUD-153:
----------------------------------------
Hi,
I just sent a patch to handle this issue:
Signed-off-by: Michal fojtik <[email protected]>
---
.../lib/deltacloud/drivers/rhevm/rhevm_driver.rb | 4 ++++
.../lib/deltacloud/helpers/application_helper.rb | 1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
index 10ffef3..8a0764c 100644
--- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
+++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
@@ -335,6 +335,10 @@ class RHEVMDriver < Deltacloud::BaseDriver
status 401
end
+ on /(not supported|custom properties are not configured)/ do
+ status 501
+ end
+
on /(InternalServerError|nodename nor servname provided)/ do
status 502
end
diff --git a/server/lib/deltacloud/helpers/application_helper.rb
b/server/lib/deltacloud/helpers/application_helper.rb
index 623fac8..e368103 100644
--- a/server/lib/deltacloud/helpers/application_helper.rb
+++ b/server/lib/deltacloud/helpers/application_helper.rb
@@ -266,6 +266,7 @@ module ApplicationHelper
when 406; { :message => "Not Acceptable" }
when 500; { :message => "Internal Server Error" }
when 502; { :message => "Backend Server Error" }
+ when 501; { :message => "Not Supported" }
end
end
--
1.7.9.1
> Unhandled exception or status code (Required VDSM hook 'floppyinject' not
> supported by RHEV-M) - 500 - Internal Server Error
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-153
> URL: https://issues.apache.org/jira/browse/DTACLOUD-153
> Project: DeltaCloud
> Issue Type: Bug
> Components: Server
> Environment: Rhel 6.2
> rpm -qa |grep deltacloud
> deltacloud-core-rhevm-0.5.0-5.el6.noarch
> deltacloud-core-0.5.0-5.el6.noarch
> rubygem-deltacloud-client-0.5.0-2.el6.noarch
> deltacloud-core-ec2-0.5.0-5.el6.noarch
> deltacloud-core-vsphere-0.5.0-5.el6.noarch
> rhevm 3.1
> Reporter: Ronelle Landy
> Assignee: David Lutterkort
>
> Attempting to create an instance with user_data in a rhevm environment where
> floppyinject hook does not exist results in an 'Unhandled exception':
> Deltacloud::ExceptionHandler::BackendError - Unhandled exception or status
> code (Required VDSM hook 'floppyinject' not supported by RHEV-M)
> The error itself is correct - the handling is not.
> Backtrace:
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_client.rb:148:in
> `create_vm'
> /usr/lib/ruby/gems/1.8/gems/nokogiri-1.5.0.beta.4/lib/nokogiri/xml/builder.rb:364:in
> `instance_eval'
> /usr/lib/ruby/gems/1.8/gems/nokogiri-1.5.0.beta.4/lib/nokogiri/xml/builder.rb:364:in
> `insert'
> /usr/lib/ruby/gems/1.8/gems/nokogiri-1.5.0.beta.4/lib/nokogiri/xml/builder.rb:350:in
> `method_missing'
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_client.rb:137:in
> `create_vm'
> /usr/lib/ruby/gems/1.8/gems/nokogiri-1.5.0.beta.4/lib/nokogiri/xml/builder.rb:291:in
> `instance_eval'
> /usr/lib/ruby/gems/1.8/gems/nokogiri-1.5.0.beta.4/lib/nokogiri/xml/builder.rb:291:in
> `initialize'
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_client.rb:136:in
> `new'
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_client.rb:136:in
> `create_vm'
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_driver.rb:206:in
> `create_instance'
> /usr/share/deltacloud-core/lib/deltacloud/base_driver/exceptions.rb:151:in
> `call'
> /usr/share/deltacloud-core/lib/deltacloud/base_driver/exceptions.rb:151:in
> `safely'
> /usr/share/deltacloud-core/lib/deltacloud/drivers/rhevm/rhevm_driver.rb:197:in
> `create_instance'
> /usr/share/deltacloud-core/lib/deltacloud/server.rb:480
> /usr/share/deltacloud-core/lib/sinatra/rabbit.rb:125:in `instance_eval'
> /usr/share/deltacloud-core/lib/sinatra/rabbit.rb:125:in `POST /api/instances'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:1151:in `call'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:1151:in
> `compile!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:724:in
> `instance_eval'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:724:in
> `route_eval'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:708:in `route!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:758:in
> `process_route'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:755:in `catch'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:755:in
> `process_route'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:707:in `route!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:706:in `each'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:706:in `route!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:843:in
> `dispatch!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:644:in `call!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:808:in
> `instance_eval'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:808:in `invoke'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:808:in `catch'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:808:in `invoke'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:644:in `call!'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:629:in `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_date.rb:31:in `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_accept.rb:149:in `call'
> /usr/lib/ruby/gems/1.8/gems/rack-1.3.0/lib/rack/head.rb:9:in `call'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/showexceptions.rb:21:in
> `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_driver_select.rb:45:in `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_matrix_params.rb:106:in `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_runtime.rb:36:in `call'
> /usr/share/deltacloud-core/lib/sinatra/rack_etag.rb:41:in `call'
> /usr/lib/ruby/gems/1.8/gems/rack-accept-0.4.3/lib/rack/accept/context.rb:22:in
> `call'
> /usr/lib/ruby/gems/1.8/gems/rack-1.3.0/lib/rack/head.rb:9:in `call'
> /usr/lib/ruby/gems/1.8/gems/rack-1.3.0/lib/rack/commonlogger.rb:18:in `call'
> /usr/lib/ruby/gems/1.8/gems/rack-1.3.0/lib/rack/methodoverride.rb:24:in `call'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:1272:in `call'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:1303:in
> `synchronize'
> /usr/lib/ruby/gems/1.8/gems/sinatra-1.2.6/lib/sinatra/base.rb:1272:in `call'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/connection.rb:84:in
> `pre_process'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/connection.rb:82:in `catch'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/connection.rb:82:in
> `pre_process'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1060:in
> `call'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1060:in
> `spawn_threadpool'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1057:in
> `initialize'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1057:in
> `new'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1057:in
> `spawn_threadpool'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:1049:in
> `defer'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/connection.rb:54:in `process'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/connection.rb:42:in
> `receive_data'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:256:in
> `run_machine'
> /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.10/lib/eventmachine.rb:256:in
> `run'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/backends/base.rb:61:in
> `start'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/server.rb:159:in `start'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/controllers/controller.rb:86:in
> `start'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/runner.rb:185:in `send'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/runner.rb:185:in
> `run_command'
> /usr/lib/ruby/gems/1.8/gems/thin-1.2.11/lib/thin/runner.rb:151:in `run!'
> /usr/share/deltacloud-core/bin/deltacloudd:235
> /usr/bin/deltacloudd:5:in `load'
> /usr/bin/deltacloudd:5
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
